SwiftcordApp / Swiftcord

A fully native Discord client for macOS built 100% in Swift!
https://swiftcordapp.github.io/Swiftcord/
GNU General Public License v3.0
1.85k stars 84 forks source link

Sticker Packs #150

Closed Sjmarf closed 1 year ago

Sjmarf commented 1 year ago

Warning This relies on DiscordKit being updated to include my recent PR.

cryptoAlgorithm commented 1 year ago

I'd have preferred if all suggested changes were batched into a single commit, but I guess this works too as it would be eventually squashed for merging.

Sjmarf commented 1 year ago

It should be good now, I think 👍

cryptoAlgorithm commented 1 year ago

It should be good now, I think 👍

Nice, there doesn't appear to be any more lint warnings/errors remaining! However, there still are some references to a local copy of DiscordKit, which shouldn't be committed.

cryptoAlgorithm commented 1 year ago

Ok, one final issue: looks like the commit hash of DiscordKit in Package.resolved is still pointing to an old commit, it needs to point to at least the commit that adds the required symbols, else building on CI will not succeed. You can follow these instructions https://github.com/SwiftcordApp/Swiftcord/pull/150#discussion_r1193153536 to update the dependancy reference.

Sjmarf commented 1 year ago

Ok, one final issue: looks like the commit hash of DiscordKit in Package.resolved is still pointing to an old commit, it needs to point to at least the commit that adds the required symbols, else building on CI will not succeed. You can follow these instructions #150 (comment) to update the dependancy reference.

Hopefully it's working now 😅