Closed Sjmarf closed 1 year ago
I'd have preferred if all suggested changes were batched into a single commit, but I guess this works too as it would be eventually squashed for merging.
It should be good now, I think 👍
It should be good now, I think 👍
Nice, there doesn't appear to be any more lint warnings/errors remaining! However, there still are some references to a local copy of DiscordKit, which shouldn't be committed.
Ok, one final issue: looks like the commit hash of DiscordKit in Package.resolved
is still pointing to an old commit, it needs to point to at least the commit that adds the required symbols, else building on CI will not succeed. You can follow these instructions https://github.com/SwiftcordApp/Swiftcord/pull/150#discussion_r1193153536 to update the dependancy reference.
Ok, one final issue: looks like the commit hash of DiscordKit in
Package.resolved
is still pointing to an old commit, it needs to point to at least the commit that adds the required symbols, else building on CI will not succeed. You can follow these instructions #150 (comment) to update the dependancy reference.
Hopefully it's working now 😅
.onTapGesture
. This means that the Bird sticker, which previously wouldn't show a preview when clicked, now works correctly.StickerItemView
. This is because the hover-detection code is reused in the sticker pack view.StickerView
(the view used to display stickers in messages) toMessageStickerView
.