search

SwiftcordApp / Swiftcord

A fully native Discord client for macOS built 100% in Swift!
https://swiftcordapp.github.io/Swiftcord/
GNU General Public License v3.0
1.85k stars 84 forks source link

macOS Sonoma Fixes #166

Closed furby-tm closed 2 months ago

furby-tm commented 1 year ago

Bit of a noisy commit, sorry about that. This repo should use a formatter, SwiftFormat is a good one.

It appears to be a SwiftUI bug, however applying a .buttonStyle() modifier, even with a PlainButtonStyle() appears to break the ability to click on any of the Server (AKA Guild) buttons -- at least on macOS 14 Sonoma. Not sure if it's functioning correctly on macOS 13 Ventura or below.

In this revision I've removed the .buttonStyle() which introduces the default style -- slightly ugly rounded rect button backgrounds to the buttons, however; it restores the functionality of these buttons in the meantime.

The work for that can be summarized in the changes within the following files:

There was also a fix for the settings window, as it does not open on versions macOS 14 Sonoma and above without being opened from within a SettingsLink closure.

If server buttons are working as expected for older versions of macOS, I can clean these changes up and work out of a macOS 14 Sonoma branch which you can merge at some point down the line.

Thanks! I appreciate your work so far on Swiftcord, the Swift community keeps getting more interesting by the day 😄.

Candygoblen123 commented 1 year ago

Hi, Thanks for the suggestion, but we already have a linter.

Could you please revert the team ID in the Xcode project back to what it was originally?