search

SwifterSwift / SwifterSwift

A handy collection of more than 500 native Swift extensions to boost your productivity.
https://swifterswift.com
MIT License
13.96k stars 1.62k forks source link

Project failed to compile because of lint errors #833

Closed spicymatt closed 4 years ago

spicymatt commented 4 years ago

[X ] I've read, understood, and done my best to follow the Contributing guidelines before opening this issue.

What did you do?

Run carthage update on a projet referencing SwifterSwift

What did you expect to happen?

Project should compile

What happened instead?

Project failed to compile because of lint errors in the macOS test cases

I open the project checked-out by Carthage and failed to compile it because of lint related errors: Variable name should only contain alphanumeric characters: e.g allTestsCalendarExtensionTests Variable name should only contain alphanumeric characters: 'allTestsDateExtensionsTests' (identifier_name) etc... 33 errors in total, all in the test package

I'm not terribly familiar with swiftlint, but I understand that the .yml that is at the root of the checked-out project takes precedence over any other configuration so I don't really see how to make it compile out of the box because those lint parameters from the project will be used.

SwifterSwift Environment

Demo Project

LucianoPAlmeida commented 4 years ago

Thanks for reporting, that's weird because all those files were removed in #808 ... So if you are using the latest version it shouldn't be a problem, anyways we can investigate that :)

spicymatt commented 4 years ago

hello, Thanks for responding...and finding the solution. For some reason, I had to delete the Carthage/ folder and redo the carthage update --platform macOS --no-use-binaries to make it work. I was using 5.1 before the first attempt, and for some reason, the Carthage checkout was not reflecting the change you mention. I should have tried to cleanup Carthage/ before asking but I never had to do it before. Thanks anyway. Matthieu PS: we were 2 people experiencing the issue...so it is not related to my machine, somehow...

LucianoPAlmeida commented 4 years ago

Right, maybe it is some Carthage caching/update problem, not really sure ... but glad you make it work :) Closing 👍