Swiip / generator-gulp-angular

Yeoman generator for AngularJS with GulpJS [UNMAINTAINED next iteration is FountainJS]
http://fountainjs.io
3.72k stars 666 forks source link

Probably something's wrong with minification #1079

Open matiishyn opened 8 years ago

matiishyn commented 8 years ago

I have a clean project, generated by this generator: Angular1.5+Bootstrap+LESS

Then installing Firebase: bower install --save firebase angularfire (https://www.firebase.com/docs/web/libraries/angular/quickstart.html)

and include firebase module into my Angular app, like this image

Now, gulp serve works great BUT gulp serve:dist (or gulp build + my server) gives an error image

similar behavior I had for some other modules.

Could you please help me to resolve it

matiishyn commented 8 years ago

this fixed the issue for me image

So probably, something wrong happened during minification

Please help me to resolve it

piu130 commented 8 years ago

I've tested it. For me it works. You just need to bower install --save angularfire because it depends on firebase. I also bumped gulp-inject, wiredep and main-bower-files to the latest version. After that I had some problem with angular and jQuery because angular then uses his own jqlite library. You have to add

"overrides": {
  "angular": {
    "dependencies": {
      "jquery": "~2.2.3"
    }
  }
}

to your bower.json if you use jQuery.

majkelo commented 5 years ago

Ok, I faced the same error. Here is the solution:

https://gist.github.com/majkelo/1fcacd3aea7c00ad2e31e2fdf696b5e9