Swiip / generator-gulp-angular

Yeoman generator for AngularJS with GulpJS [UNMAINTAINED next iteration is FountainJS]
http://fountainjs.io
3.72k stars 665 forks source link

ui-bootstrap directive not working util change to use 0.14.x version #856

Open pluswave opened 9 years ago

pluswave commented 9 years ago

hello, while I use generator-gulp-angular 1.0.0 for default settings, I found that it failed for very simple ui-bootstrap directives(see below code), then after upgrading it to 0.14.2 in bower.json, issue resolved.

<uib-accordion close-others="true">
  <uib-accordion-group heading="Static Header">
    This content is straight in the template.
  </uib-accordion-group>
</uib-accordion>

but I am not sure, it is good to simply have this patch:

diff --git a/app/templates/_bower.json b/app/templates/_bower.json
index 255a021..36d4ab1 100644
--- a/app/templates/_bower.json
+++ b/app/templates/_bower.json
@@ -49,7 +49,7 @@
     "material-design-lite": "~1.0.4",
     "material-design-iconfont": "~0.0.2",
 <% } if(props.bootstrapComponents.key === 'ui-bootstrap') { -%>
-    "angular-bootstrap": "~0.13.4",
+    "angular-bootstrap": "~0.14.2",
 <% } if(props.bootstrapComponents.key === 'angular-strap') { -%>
     "angular-strap": "~2.3.1",
 <% } if(props.foundationComponents.key === 'angular-foundation') { -%>
Swiip commented 9 years ago

I didn't test every directive of ui bootstrap with the generator. If an simple update fix it, I doubt it's an important problem. You can PR your update, thanks.

DaAwesomeP commented 8 years ago

This is a result of using an older version of UI Bootstrap than their docs show. At the top of their docs there is a "Previous docs" dropdown. Try the latest 0.13.x release.