search

Swinject / SwinjectAutoregistration

Swinject extension to automatically register your services
MIT License
249 stars 45 forks source link

Update to support Xcode 10.2 #46

Closed mpdifran closed 5 years ago

mpdifran commented 5 years ago

This also resolves a few warnings that popped up in the new Xcode.

mpdifran commented 5 years ago

Thanks for making the changes, I've incorporated them to the PR. I totally missed that when I opened the PR.

tkohout commented 5 years ago

@mpdifran Hello! Thanks for all the work! The Autoregistration.swift file is dynamically generated, would you mind looking into bin/generate script and changing it accordingly? There is another pull request https://github.com/Swinject/SwinjectAutoregistration/pull/45/files solving this but it seems it changes different lines.

I am still in process of updating to the newest XCode which might take some time (bad Internet connection), so I don't know what exactly is the problem.

Thanks!

mpdifran commented 5 years ago

Why is Travis taking so long to build?

freak4pc commented 5 years ago

I think the problem isn't the build time, but the queueing time 😂

mpdifran commented 5 years ago

Looks like the build is succeeding now. The one job failed because we maxed out GitHub API calls. Can someone just run that job again?

mpdifran commented 5 years ago

Anything preventing this from getting merged?

enoelboostmi commented 5 years ago

Is there anything missing to merge an release this PR by any chance?

tkohout commented 5 years ago

Seems good to me, thanks! I will merge this and release new version. We will look into the swift 5 in the next minor version.