search

Swinject / SwinjectAutoregistration

Swinject extension to automatically register your services
MIT License
251 stars 45 forks source link

Swift 5 #48

Closed killev closed 4 years ago

killev commented 5 years ago

Hi,

I've added swift5 support and upgraded code to the most recent versions of Swinject, Qiuick and Nimble.

Regards, Peter

tkohout commented 5 years ago

I'm trying to keep the swift version consistent with the main Swinject repo (which is still on 4.2 as far as I can see) - https://github.com/Swinject/Swinject/issues/407

I am not really sure, what is the correct way to handle this. I don't want to force people to switch to Swift 5 just yet. Any idea how other open source projects handle this? Maybe maintain a separate swift 5 branch for now?

jakubvano commented 5 years ago

AFAIK migrating to Swift 5 won't force developers to use Swift 5 in their projects - just compiler which supports Swift 5 i.e. Xcode 10.2 - all that matters for module compatibility should be compiler vesion, not Swift version.

I would be comfortable with dropping support for older compilers - AFAIK there haven't been any significant changes for quite some time

tkohout commented 4 years ago

Closing in favour of https://github.com/Swinject/SwinjectAutoregistration/pull/54

Thanks!