search

Swinject / SwinjectAutoregistration

Swinject extension to automatically register your services
MIT License
251 stars 45 forks source link

Swift 3 support #7

Closed jakubvano closed 7 years ago

jakubvano commented 7 years ago

Updated dependencies and API to match Swinject v2 and Swift 3 guidelines

tkohout commented 7 years ago

Hello! thanks for the pull request.

I have changed the syntax a little bit according to https://github.com/Swinject/SwinjectAutoregistration/issues/1

Can you fix the conflicts so I can merge it?

Thanks

jakubvano commented 7 years ago

👍 Will do, probably on Monday.

jakubvano commented 7 years ago

Rebased branch on current master, including syntax changes.

jakubvano commented 7 years ago

I have changed assertionFailure to fatalError, because former is ignored in release builds, which is problem when integrated via Carthage.

I added change to this PR for convenience - if we plan to maintain 2.x version this should be changed there as well.

tkohout commented 7 years ago

Thanks for the contribution 👍