search

Swinject / SwinjectAutoregistration

Swinject extension to automatically register your services
MIT License
249 stars 45 forks source link

Update Carthage and set minimum versions to 9 #77

Closed mpdifran closed 2 years ago

mpdifran commented 2 years ago

Looks like minimum versions were set much higher (iOS 12, watchOS 3, etc). I set them to the smallest value possible, and the project still builds.

Once merged and released, this should fix https://github.com/Swinject/Swinject/issues/498

I wasn't able to get cocoa pods updated, pods is broken on my current machine.

yoichitgy commented 2 years ago

Thanks @mpdifran for making the PR! The changes themselves are good to me, but CI failed. Can we ignore the CI failure?

tkohout commented 2 years ago

Thanks for the PR!

We're out of credits on Travis, I ran this locally and all tests are passing so I think it's safe to merge this.