Swinject / SwinjectPropertyLoader

Swinject extension to load property values from resources
MIT License
28 stars 19 forks source link

Fix pod instruction had wrong version #12

Closed gregpardo closed 7 years ago

yoichitgy commented 7 years ago

Thanks @gregpardo for the pull request😃 but SwinjectPropertyLoader version 1 is used with Swinject version 2😉

I was thinking whether the version number of SwinjectPropertyLoader should match that of Swinject before releasing SwinjectPropertyLoader. The current version of SwinjectPropertyLoader has possibility to support Swinject version 3 in the future, and version number mismatch can happen, so I released SwinjectPropertyLoader as version 1.

gregpardo commented 7 years ago

Okay that makes sense. I simply tried to install using the instructions and failed. Also the Carthage section will need to be changed to both be 2

yoichitgy commented 7 years ago

Sorry @gregpardo for the inconvenience. I fixed README.md to give the correct instruction of Cartfile. Thanks for the feedback😃