search

Swinject / SwinjectPropertyLoader

Swinject extension to load property values from resources
MIT License
28 stars 19 forks source link

Substring changes #15

Closed edpelesh closed 3 years ago

edpelesh commented 6 years ago

Fixed deprecation warnings that blocked Carthage to finish updating.

kreeger commented 6 years ago

This is hanging me up, too. I'd love to see this merged in.

yoichitgy commented 6 years ago

Thanks @edpelesh for the PR and sorry that I took time so long to respond. We need to fix the CI failure to merge this PR.

yoichitgy commented 6 years ago

I'll try checking the CI failure, but it's really appreciated if you investigate the problem.

edpelesh commented 6 years ago

I've added a compilation conditional check. Please, check this solution. I doesn't look very clean, but at least it does what it needs.

serebryakov7 commented 6 years ago

So, can it be merged?

VEnis commented 6 years ago

+1 for merge

yoichitgy commented 3 years ago

Thank you for making the PR😃 and sorry for taking too long time to response.

It looks the similar change is covered by PR #20. Let me close this PR🙏