Swift 5 Migration - Githubissues

Swinject / SwinjectPropertyLoader

Swinject extension to load property values from resources

MIT License

28 stars 19 forks source link

Swift 5 Migration #22

Closed vitallica closed 3 years ago

vitallica commented 5 years ago

Update Carthage dependencies.
Fix references to macOS configs based on updated xcconfigs repository.
Fix some warnings around wrong version of Swinject.framework being referenced for different platforms.
Run Xcode Conversion tool for all targets.
Update all SWIFT_VERSION entries to 5.0

vitallica commented 5 years ago

@jakubvano Please review this PR. The project is now compatible with Swift 5 (Xcode 10.2). I've also fixed some compiler warnings that could eventually become errors.

Please update the release tag as well, so that github "Swinject/SwinjectPropertyLoader" in Cartfile points to the latest changes. Thank you.

vitallica-2b commented 5 years ago

@yoichitgy

vitallica-2b commented 5 years ago

@jakubvano @Lutzifer @tkohout @yoichitgy this has been open for more than a month, and is referenced from an open issue. Please review and merge. Thank you.

yoichitgy commented 3 years ago

Thank you for making the PR😃 and sorry for taking too long time to merge it🙏