Fix carthage build - Githubissues

Swinject / SwinjectStoryboard

Swinject extension for automatic dependency injection via Storyboard

MIT License

268 stars 142 forks source link

Fix carthage build #140

Open gilroykilroy opened 4 years ago

gilroykilroy commented 4 years ago

Fix carthage build by checking in the generated Swift header file into the project. Perhaps some tweaking of search paths would solve the problem too but I could not figure that out.

Lex-Nagtegaal commented 4 years ago

when will this pull request be merged?

yoichitgy commented 3 years ago

Thank you for making the PR😃 and sorry for taking too long to respond🙇‍♂️

I'm not sure we still see the issue when using Carthage.

carthage-build.sh made in PR #156 might help users of Carthage.
Support of xcframework might be alternative.
Not sure but we'll see possibility that Carthage itself fixed the issue.

mpdifran commented 3 years ago

Yeah I don't think this is necessary. The included ./carthage-build.sh helps get around the build issue when not using xcframeworks, and we'll add xcframework support in the next major version.