Swinject / SwinjectStoryboard

Swinject extension for automatic dependency injection via Storyboard
MIT License
267 stars 144 forks source link

Fix SwinjectStoryboardOption to conform ServiceKeyOption #151

Closed YamatoOtaka closed 4 years ago

YamatoOtaka commented 4 years ago

Description

I noticed this issue because Carthage build was failing due to a compilation error in SwinjectStoryboardOption

internal struct SwinjectStoryboardOption: ServiceKeyOption {
                ^
Swinject.ServiceKeyOption:3:10: note: protocol requires function 'hash(into:)' with type '(inout Hasher) -> ()'
    func hash(into: inout Hasher)
         ^

** ARCHIVE FAILED **

I checked that it can be compiled without problems if it conforms to ServiceKeyOption protocol. I would appreciate your feedback🙏

YamatoOtaka commented 4 years ago

Oh, it was already supported. https://github.com/Swinject/SwinjectStoryboard/pull/135 When is the next release?