search

Swinject / SwinjectStoryboard

Swinject extension for automatic dependency injection via Storyboard
MIT License
267 stars 144 forks source link

Error while building SwinjectStoryBoard with XCode 12.5 #154

Closed shalinipk closed 3 years ago

shalinipk commented 3 years ago

Anyone ran into this build error ?

SwinjectStoryboard/Sources/iOS-tvOS/UIStoryboard+Swizzling.m:55:13: error: cast to smaller integer type 'BOOL' (aka 'signed char') from 'id' [-Werror,-Wpointer-to-int-cast]
        if ((BOOL)[[SwinjectStoryboard class] performSelector:@selector(isCreatingStoryboardReference)]) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I ended up manually removing the BOOL type casting so that carthage builds.

My cartfile entry looks like this - github "Swinject/SwinjectStoryboard" "0ca45c83a8aa398c153d8a036c95abb4343cfa0c"

Looking forward to version 2.2.1 for SwinjectStoryboard. Thanks!!

j0d5 commented 3 years ago

Also looking forward! :)

Bawenang commented 3 years ago

Is there any news about this fix? I see that there are two pull reqs that are trying to fix this bug.

yoichitgy commented 3 years ago

Merged PR #155 and closing this issue. Thanks!