search

SwipeX / PokeMate

Automated PokemonGo Application
GNU General Public License v3.0
111 stars 45 forks source link

Cleaner pokestop tag #213

Closed gsisso closed 8 years ago

kylestev commented 8 years ago

@gsplash awesome. just waiting on Codacy and Travis before merging!

kylestev commented 8 years ago

@gsplash Have you joined Slack? The information is in the README.

kylestev commented 8 years ago

Thanks for fixing that up.

kylestev commented 8 years ago

Uh oh. The build failed @gsplash

kylestev commented 8 years ago

You'll want to take a look at the push I just made. In particular SwipeX/PokeMate@b8ea1d699bb80d994a308e7097d17d1eb2dc840a

kylestev commented 8 years ago

@gsplash the issue is that you have not pulled the changes from this repository. I rebased it and merged it for you. See SwipeX/PokeMate@87a1fcf26163aa326eca2af03b6fe90752500295

gsisso commented 8 years ago

@kylestev I already changed the string converter in few previous commits ,it just failed because StringConverter.titleCase(ItemId.valueOf(item.getKey()).name()) should be (StringConverter.titleCase(ItemId.valueOf(item.getKey()).name())) dunno why it cant build it this way ,my compiler does it just fine. anyway I fixed it and you might want to pull the latest commit as well

kylestev commented 8 years ago

But you did not have the change for titleCase pushed to github, thus the failing check -- it was not because of the parenthesis around StringConverter and the method call. I tried compiling your branch locally and the build failed both prior to and after you added the parenthesis.

You can see the branch diff here https://github.com/gsplash/PokeMate/compare/master...SwipeX:master