search

Swirrl / datahost-prototypes

Eclipse Public License 1.0
0 stars 0 forks source link

ensure dataset column types match the ones in Release schema #268

Closed rosado closed 1 year ago

rosado commented 1 year ago

Tablecloth guesses the column types based on values present in the dataset. If we have a column with one row and value 75, in a column where we expect a floating point value, the column type will be int.

This change updates the as-dataset function to optionally take a :convert-types option (along with DataseRow) to do the conversion.

RickMoynihan commented 1 year ago

This looks good to me, so happy to merge. Thanks again @rosado 🙇

Though I've noticed a couple of unrelated issues whilst testing this which I'll coin new issues for.