search

Swirrl / drafter

A clojure service and a client to it for exposing data management operations to PMD
Other
0 stars 0 forks source link

Configured base-uri enhancement #609

Closed scottlowe closed 2 years ago

scottlowe commented 2 years ago

This PR enhances the base-uri as a configured default which can be supplied as the DRAFTER_BASE_URI environment variable.

Note

This PR supercedes PR https://github.com/Swirrl/drafter/pull/601 and removes the ability (from that PR) to provide a different base-uri when you upload a file.

RickMoynihan commented 2 years ago

Can confirm it does what it says on the tin 👌 ... just going to skim the diffs once more before merging...

RickMoynihan commented 2 years ago

Thanks @scottlowe this looks great and works perfectly. 🙇

I made a small tweak to hardcode the BaseURI in the dev environment (so no need to document anywhere other than the production configuration docs). So I moved that from the drafter-client README to the right place.

The confusingly named config file fix is unrelated to this PR, it's just something tiny I spotted when I was here.