Swirrl / drafter

A clojure service and a client to it for exposing data management operations to PMD
Other
0 stars 0 forks source link

Review some query patterns in the draft management namespace #645

Closed scottlowe closed 1 year ago

scottlowe commented 1 year ago

Lee has asked if we need the following:

   Do we need the `[subject '?p '?o]` pattern here? Neither `?p` nor `?o` are used in the rest of the query.

_Originally posted by @lkitching in https://github.com/Swirrl/drafter/pull/644#discussion_r992529036_

Also https://github.com/Swirrl/drafter/pull/644#discussion_r992533452

I simply executed a straight port from the original string concat SPARQL query to the Flint DSL for those queries. It is not clear to me what the intent of the seemingly unused pattern is.

scottlowe commented 1 year ago

I have made the changes now that Ric has confirmed that it looks okay to do so.