search

Swirrl / ons-data-export

Temporary repo to keep track of the extraction of data between the PMD3 backed alpha for the COGS project, and the PMD4 staging server.
0 stars 0 forks source link

dimensions without qb:codeList #13

Closed jennet closed 4 years ago

jennet commented 4 years ago

This CSV shows the 18 dataset components that are using codes but do not have a qb:codeList set up currently (currently, PMD4 uses the qb:codeList object to load up the filter modal dialogs for users to pick which concept values to filter the data by)

https://github.com/Swirrl/ons-data-export/blob/master/data-issues/dimensions_and_data_values/components_dims_schemes.csv

There is ongoing discussion about how to handle this going forward, but for now we should put in place a temporary fix in the data on for the staging site.

Is it best to manually add different dimensions for now that have qb:codeList set (so that it works with the current PMD4 code base in use on cogs-staging), or would this introduce more problems that I may not have thought of?

jennet commented 4 years ago

From the CSV it looks like the dimension http://gss-data.org.uk/def/dimension/trade-reporter-geography could have a qb:codeList of http://gss-data.org.uk/def/concept-scheme/nuts-geography added as a simple fix (see #11)

jennet commented 4 years ago

Suggestion: Manually add 9 dimensions to the cogs-staging data with qb:codeList for:

http://gss-data.org.uk/def/concept-scheme/sitc-4
http://gss-data.org.uk/def/concept-scheme/hmrc-industry-groups
http://gss-data.org.uk/def/concept-scheme/itis-services
http://gss-data.org.uk/def/concept-scheme/ons-functional-category
http://gss-data.org.uk/def/concept-scheme/cord-sitc
http://gss-data.org.uk/def/concept-scheme/ons-abs-trades
http://gss-data.org.uk/def/concept-scheme/bop-services
http://stamina-project.org/codes/cpav2008/cpa
http://gss-data.org.uk/def/concept-scheme/pink-book-services

And change the DSD components to use these dimensions instead

jennet commented 4 years ago

These have had manual fixes on cogs-staging but will require adjustments to ONS data generation configuration to stop the issue being reintroduced