Swirrl / ook

Structural search engine
https://search-prototype.gss-data.org.uk/
Eclipse Public License 1.0
6 stars 0 forks source link

Codes say they're in NUTS scheme but don't show up when building the tree top-down #104

Closed kiramclean closed 3 years ago

kiramclean commented 3 years ago

This causes some search results to return an empty codelist. E.g. search "Geography" for "wales" to see this:

image

The reason the NUTS scheme appears but is empty is because the search returns some codes that are marked as being in that codelist, but don't appear when the tree is built from the top-down (which is how we currently fetch the data to build the tree UI).


In case it's helpful, these are the steps I did to get a hold of the relevant data and convince myself of what's going on (I did these from a repl with the namespaces from ook.search.elastic.codes loaded):

Robsteranium commented 3 years ago

I think this might be a mistake in the data. What I have loaded locally includes the jsonld equivalent of:

<http://data.europa.eu/nuts/code/UK> skos:topConceptOf <http://data.europa.eu/nuts/scheme/2016>

I believe this should solve the problem.

The gap was likely caused by the previous loading behaviour as with #69 (where unordered limit/offset paging wasn't contiguous).

We should look to confirm this once the current pipeline run is complete.

Robsteranium commented 3 years ago

The new data didn't resolve it, but #107 did (incidentally).