search

Swirrl / ook

Structural search engine
https://search-prototype.gss-data.org.uk/
Eclipse Public License 1.0
6 stars 0 forks source link

Edit facets #67

Closed kiramclean closed 3 years ago

kiramclean commented 3 years ago

This makes facets editable. The code tree(s) should be expanded to show the minimum view required to see all selected codes, whether you edit a facet that has already loaded or you come from a URL with a filter state already set.

Editable facets get a little pencil icon, like this:

image

Closes #62

Robsteranium commented 3 years ago

The svg pencil icon isn't visible on FF 88 for Ubuntu. I can see it on Chromium 90.0.4430.72 though.

Other than that this seems to work really well. The automatic collapsing of branches without selections is great.

kiramclean commented 3 years ago

It looks like I can see the icon on ff 89.0b3 (64-bit) for macos 11.2.3, weird that it would OS-specific, but I guess it is somehow? image

Robsteranium commented 3 years ago

It's working for me now... Not sure that anything has changed (although I did a CTRL-SHIFT-R earlier on a different branch so that might play a role).

Let's merge this!