Switch dataset facets query to use aggregation instead of collapse

Swirrl / ook

Structural search engine

https://search-prototype.gss-data.org.uk/

Eclipse Public License 1.0

6 stars 0 forks source link

Switch dataset facets query to use aggregation instead of collapse #68

Closed Robsteranium closed 3 years ago

Robsteranium commented 3 years ago

This switches over the facet query to use aggregation as per #52.

Outstanding issues:

pmd-link

[x] needs to select all matching codes (not just first)
[x] shouldn't apply filters to dimensions with codelist (and not code) selections (matches are examples not criteria to carry forward)

layout

[x] needs to say "top 3 were selected"
[ ] could add an ellipsis to indicate "even more matches are available" if were to extract a 4th match?
[ ] table is too wide ~- maybe add newline between matches?~

Robsteranium commented 3 years ago

Screenshot demonstrating the width problem we encounter with e.g. this query:

I'd previously wondered about putting each code on a new line but we're using newlines to distinguish dimensions.

Perhaps we could trim and add an ellipsis to labels? Maybe set a max column width?

I wonder if we should remove the max-width/ margin-auto from the overall container (or otherwise reduce the margins) so the table can take up more of the available page when it needs to.