search

Swirt / typertools-src

Public builds - https://swirt.github.io/typertools/
MIT License
42 stars 24 forks source link

fix: check font.family of current iteration with current family #68

Open mangkoran opened 4 months ago

mangkoran commented 4 months ago

First of all, thank you for developing such amazing tool. I just started to learn about scanlating yesterday and found TyperTools very helpful. I hope this tools could help many for generations to come.

This PR should address #56 where the font family will unexpectedly change if we would like to change font style. This is due to the logic currently used only check for font.style which will make the first font that have the selected style will be chosen instead of the correct one. This PR adds a check font.family === family.

Current master ![Photoshop_blzi3HEmul](https://github.com/Swirt/typertools-src/assets/57625126/3cf20eed-043e-4b5e-bac0-e4bdd3a00967)
This PR ![Photoshop_6FQC6cbEQr](https://github.com/Swirt/typertools-src/assets/57625126/73dd4f6a-c38e-4445-80cc-0b76c4cac84a)

Tested on

Fix #56

mangkoran commented 4 months ago

Friendly mention @Swirt :D

mangkoran commented 3 weeks ago

Cc @Swirt sorry to bump this PR, but is there anything that should be done before this PR could be merged?