Closed olevski closed 1 month ago
@sgaist I spent half the day trying to figure out why the owner references were failing in the tests. So I went back to what you had before and what I made you change. We should have kept that since it is what the k8s docs recommend. My bad about that.
With the SetControllerReference (as you had it earlier) things do not fail. They way I proposed was fragile because sometimes the kind/apiversion can be empty and the SetControllerReference handles this gracefully.
@sgaist
I did a few changes from your version that was just merged:
controllerutil
library to simplify reconciliationA few things that are still missing, that I will do in a followup PR: