SwissDataScienceCenter / amalthea

A kubernetes operator for spawning and exposing interactive user session servers.
Apache License 2.0
14 stars 4 forks source link

fix(crd): use optional in place of omitempty for authentication.enabled #652

Closed sgaist closed 1 month ago

sgaist commented 1 month ago

Describe your changes

omitempty triggers a strange behaviour: even if enabled is set to false in the CRD yaml, it will get the default value on initial apply call.

Using the optional markers keeps the CRD definition but without that unexpected behaviour.

Issue ticket number and link

Related to #614 and #637 Part of https://github.com/SwissDataScienceCenter/renku/issues/3679