search

SwissDataScienceCenter / contributed-project-templates

A repository of community-developed project templates.
Apache License 2.0
4 stars 15 forks source link

mmoda/smartsky templates (with icons!) #16

Open volodymyrss opened 1 year ago

volodymyrss commented 1 year ago

In our common SmartSky SDSC project, we could really benefit from some adapted templates. I checked that they work as a custom source.

rokroskar commented 9 months ago

@volodymyrss should this be reviewed again?

volodymyrss commented 9 months ago

@volodymyrss should this be reviewed again?

Thanks for the ping, let us just revise it with the latest plugin versions. @burnout87 could you please help?

In relation to https://github.com/oda-hub/hugo-odahub/issues/70

rokroskar commented 9 months ago

ok thanks! When you're done please re-request the review.

burnout87 commented 9 months ago

I added the two plugins in the requirements, in addition to some brief README inputs.

I also tried to implement the suggested changes for the Dockerfile of the mmoda template.

burnout87 commented 8 months ago

I cannot request for review, but I applied the two suggested changes @rokroskar

burnout87 commented 8 months ago

One last question: I added the two plugins (renku-graph-vis and renku-aqs-annotation) inside the requirements.txt, would it make more sense to have those listed within the environment.yml?

rokroskar commented 8 months ago

One last question: I added the two plugins (renku-graph-vis and renku-aqs-annotation) inside the requirements.txt, would it make more sense to have those listed within the environment.yml?

I think that's up to you. From the POV of the image build it's the same.

burnout87 commented 8 months ago

One last question: I added the two plugins (renku-graph-vis and renku-aqs-annotation) inside the requirements.txt, would it make more sense to have those listed within the environment.yml?

I think that's up to you. From the POV of the image build it's the same.

thanks, I think it's ready for review now

burnout87 commented 7 months ago

Did you manage to take a look at this @rokroskar ?