SwissDataScienceCenter / renku-python

A Python library for the Renku collaborative data science platform.
https://renku-python.readthedocs.io/
Apache License 2.0
37 stars 29 forks source link

verify that InvalidTemplateError is thrown correctly #2123

Closed sentry-dev-app[bot] closed 3 years ago

sentry-dev-app[bot] commented 3 years ago

The error (with a message that .renku is missing) is returned on the migration check of this project which contains the .renku folder (but not the .renku/renku.ini file).

Sentry Issue: RENKU-PYTHON-HS

InvalidTemplateError: Folder .renku is required for the template to be valid
(18 additional frame(s) were not displayed)
...
  File "renku/core/management/migrate.py", line 75, in is_template_update_possible
    return _update_template(client, check_only=True)
  File "renku/core/management/migrate.py", line 153, in _update_template
    project.template_source, project.template_ref
  File "renku/core/commands/init.py", line 382, in fetch_template
    template_manifest = read_template_manifest(template_folder, checkout=True)
  File "renku/core/commands/init.py", line 456, in read_template_manifest
    validate_template(template_path)
  File "renku/core/commands/init.py", line 405, in validate_template
    raise errors.InvalidTemplateError("Folder {0} is required for the template to be valid".format(folder))
Panaetius commented 3 years ago

handled in https://github.com/SwissDataScienceCenter/renku-python/issues/2125 and https://github.com/SwissDataScienceCenter/renku-python/issues/2124