search

SwissDataScienceCenter / renku-python

A Python library for the Renku collaborative data science platform.
https://renku-python.readthedocs.io/
Apache License 2.0
37 stars 29 forks source link

implement renku show with new storage backend #2261

Closed Panaetius closed 3 years ago

Panaetius commented 3 years ago

renku show (sub)commands are currently not implemented with the new database backend and should be reimplemented.

The main command that is important is renku show outputs, which is used by the pre-commit hook to check if any generated output files have been modified by the user.

renku show inputs is second priority, with renku show siblings being lowest priority.

The --revision flag for these commands doesn't make sense anymore. It never shows the status at a revision, instead if would just limit the paths argument to paths touched in commits from revision..HEAD, which still just looking at the metadata in HEAD. So I think this can be left out.

Panaetius commented 3 years ago

Add as renku workflow inputs, renku workflow outputs, leave out siblings.

Also remove show outputs githook after verifying that modifying generated outputs doesn't break the project.