SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

Certain autosave branch names crash the ui #2086

Closed olevski closed 2 years ago

olevski commented 2 years ago

A user reported the following:

Good morning Renku team, since yesterday I'm having some problems starting a new session on Renku on one project: a warning message tells me that there is no image available but whenever I want to choose a specific commit, the page goes blank. If I don't try to choose a commit, the page is stuck at 'checking sessions status'. I have tried: to load a session from an other browser restarting a new image build with a new commit logout, login Maybe related: yesterday I had this problem for any project (from my namespace and from 'omnibenchmark') but it disappeared after some time (except this one project). Any idea what is the problem and how I could solve it ?

Here is what their browser console looks like: image

The problem was resolved after the user deleted the autosave branch. The name of the branch was like this renku/autosave/fname.lname@uzh.ch/master/08007f6/134cf16. I removed the actual first and last name for privacy but there was nothing weird there.

I will check how the notebook service handles this branch. But I think it should be fine because the format is as expected and the name does not even have special character or anything else that could cause trouble.

olevski commented 2 years ago

This was the project where this problem occurred: https://renkulab.io/projects/omnibenchmark/omni_clustering/filter-expression

olevski commented 2 years ago

I can replicate the issue by cloning the project, then going to gitlab and creating a new autosave branch from master with the same name as above except with my user's email.

This is the response from the notebooks for the austoaves:

{
    "autosaves": [{
        "branch": "master",
        "commit": "08007f6",
        "date": "2022-10-20T06:29:22+00:00",
        "name": "renku/autosave/tasko.olevski@sdsc.ethz.ch/master/08007f6/134cf16",
        "pvs": false
    }],
    "pvsSupport": true
}