search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

[ShapeUp] feat: add secrets #3101

Closed lorenzo-cavazzi closed 4 months ago

lorenzo-cavazzi commented 5 months ago

Secrets in the UI -- feature branch

/deploy renku=release-0.52.x

fix #3100

RenkuBot commented 5 months ago

You can access the deployment of this PR at https://renku-ci-ui-3101.dev.renku.ch

lorenzo-cavazzi commented 4 months ago

@ciyer I added your suggestions to the code, although not all browsers consider that option image

leafty commented 4 months ago

@ciyer I added your suggestions to the code, although not all browsers consider that option

Note: It looks like it's added from a chrome extension, not the base browser itself.

RenkuBot commented 4 months ago

Tearing down the temporary RenkuLab deplyoment for this PR.

lorenzo-cavazzi commented 4 months ago

Note: It looks like it's added from a chrome extension, not the base browser itself.

@leafty That's actually the Firefox browser spellcheck.

On top of that, I also have a browser extension that would take priority and ofc ignore the setting as well :laughing:

The additional icon on the right side of the field was misleading, it was temporarily off. It shows slightly differently when it's enabled on the page and it finds errors.

image