search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

[ShapeUp] feat: update start session with options #3109

Closed lorenzo-cavazzi closed 4 months ago

lorenzo-cavazzi commented 4 months ago

This PR implements the second part of https://github.com/SwissDataScienceCenter/renku-ui/issues/3100 ,changing the "Start with options" page to include secrets.

re https://github.com/SwissDataScienceCenter/renku-ui/issues/3100

/deploy #notest renku=build/secrets-in-sessions renku-data-services=pitch/secret-storage secrets-storage=pitch/secret-storage extra-values=secretsStorage.encryptionKey=vMqdVXcSIwjwONvGiNE2vjzRjmi8NJ8Y9lTB8m3l/Xg=

RenkuBot commented 4 months ago

You can access the deployment of this PR at https://renku-ci-ui-3109.dev.renku.ch

lorenzo-cavazzi commented 4 months ago

Thank you for your suggestions @ciyer I implemented everything, except the toggle logic in the reducer -- see the motivations inline. I can still change it if you think your solution is more convenient.

RenkuBot commented 4 months ago

Tearing down the temporary RenkuLab deplyoment for this PR.