search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

feat: project page overview V2 (data sources) #3120

Closed andre-code closed 3 months ago

andre-code commented 4 months ago

PR to add ata sources in a v2 project. Should be able to add, remove, see details, edit a data source.

data source

/deploy renku=release-0.52.x

RenkuBot commented 4 months ago

You can access the deployment of this PR at https://renku-ci-ui-3120.dev.renku.ch

andre-code commented 4 months ago

Code looks OK. 🙌

Can you do a contrast check here. The labels do not seem to have enough contrast here. Screenshot from 2024-05-08 15-08-45

Comment: we have so much space here, why do we not have the actions directly available as buttons? It feels annoying to do two clicks. Screenshot from 2024-05-08 15-08-57

Big thanks @leafty for reviewing the code! 🙌 I'll definitely bring up your point about the two clicks needed to remove or update the data source with Jimena. Maybe she can take it into account for the new redesign of Renku 2.0. For now, I think it's crucial to maintain consistency in how we interact with the session launcher and data sources in the side panel. Having uniform styles for those actions.

RenkuBot commented 3 months ago

Tearing down the temporary RenkuLab deplyoment for this PR.