fix: show a full page 404 when a project is not accessible

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform

https://renkulab.io

Apache License 2.0

13 stars 6 forks source link

fix: show a full page 404 when a project is not accessible #3162

Closed leafty closed 1 month ago

leafty commented 1 month ago

Details:

Add a "Error 404 - Project no found" page with contents similar to v1 not found page.
Refactor the project page v2 routing and components (see <Outlet> and useOutletContext())

Examples:

/deploy

RenkuBot commented 1 month ago

You can access the deployment of this PR at https://renku-ci-ui-3162.dev.renku.ch

leafty commented 1 month ago

praise: This code improvements here are very nice, and the use of Outlet allows for a better structure to the project page!

I found a situation were the new 404 page should be shown, but the old error message is still displayed: https://renku-ci-ui-3162.dev.renku.ch/v2/projects/foo/test/sessions/01HZ79337RV3CCZCQSMW8F0V5F/start

Fixed in 7e1015304d1c531ebf2db3d20fc64e6b0daeaf9c.

leafty commented 1 month ago

@ciyer can you re-approve? There was a merge conflict and also the "Delete" button redirected to nowhere (fixed).

RenkuBot commented 1 month ago

Tearing down the temporary RenkuLab deplyoment for this PR.