fix: show a full page 404 when a group is not accessible

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform

https://renkulab.io

Apache License 2.0

13 stars 6 forks source link

fix: show a full page 404 when a group is not accessible #3176

Closed leafty closed 4 months ago

leafty commented 4 months ago

Details:

Add a "Error 404 - Group no found" page.
Small refactoring for routing.

Example: https://renku-ci-ui-3176.dev.renku.ch/v2/groups/no-group

/deploy

RenkuBot commented 4 months ago

You can access the deployment of this PR at https://renku-ci-ui-3176.dev.renku.ch

leafty commented 4 months ago

praise: very nice harmonization of how groups and projects are handled in this respect.

A few things I noticed while testing:

The error page for https://renku-ci-ui-3176.dev.renku.ch/v2/groups/new when not logged in looks off:

A blank page is shown if the URL for the group has multiple path components. https://renku-ci-ui-3176.dev.renku.ch/v2/groups/foo/bar

Done in 7fcc7f152ed9c2639c23c6c97c8427140683074f.

RenkuBot commented 4 months ago

Tearing down the temporary RenkuLab deplyoment for this PR.