search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

Code refactoring + tests for starting v2 sessions with data sources #3209

Closed ciyer closed 2 weeks ago

ciyer commented 3 weeks ago

/deploy renku=ciyer/release-0.53.2

ciyer commented 3 weeks ago

I noticed that the part in the StartSessionFromLauncher component where we get the currentSessionClass can be extracted into a custom hook. Feel free to include this change, or I can handle it in the PR for the resource class since I will be working on that section.

This is a good suggestion. I did not initially do that because I thought it would disrupt your work, but if you are OK with it, I will make this change.

RenkuBot commented 3 weeks ago

You can access the deployment of this PR at https://renku-ci-ui-3209.dev.renku.ch

ciyer commented 2 weeks ago

I noticed that the part in the StartSessionFromLauncher component where we get the currentSessionClass can be extracted into a custom hook. Feel free to include this change, or I can handle it in the PR for the resource class since I will be working on that section.

I looked at doing this, but on second thought, I think it is better if you make the change. After looking at your PR, I did not understand how best to do this refactoring and keep it easy for you to make your changes at the same time.

I have one suggestion: please include the cloud storage values in the startSessionOptionsV2 object.

Done.

Additionally, are you planning to include the refactor of the CloudStorageModal in this PR?

I add this in 09dd2bcc9b78e14369a32fd3ba6af3f95a39b6cd.

RenkuBot commented 2 weeks ago

Tearing down the temporary RenkuLab deplyoment for this PR.