search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

fix: do not hide secret value input field #3233

Closed leafty closed 2 months ago

leafty commented 3 months ago

Fixes #3226.

Screenshot 2024-07-09 at 14 42 56 Screenshot 2024-07-09 at 14 43 00

/deploy #notest

RenkuBot commented 3 months ago

You can access the deployment of this PR at https://renku-ci-ui-3233.dev.renku.ch

leafty commented 3 months ago

I tested this, and it works as advertised, but I have a comment.

This change causes the secrets to interact with my password manager, and I'm not sure that is what we want. Before, the field was treated as just a regular text field, and therefore ignored by the password manager, and I personally prefer that UX. I'm assuming that was the motivation for the initial implementation.

In that case we would simply have a text area field and the value would be visible (i.e. we remove the clumsy blur filter). That is how some apps handle secrets.

RenkuBot commented 2 months ago

Tearing down the temporary RenkuLab deplyoment for this PR.