search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

feat: reflect Renku 2.0 search in the URL #3245

Closed leafty closed 1 month ago

leafty commented 1 month ago

Closes #3157.

The search page in Renku 2.0 has been reworked to make the search query and search options be reflected in the browser's URL.

/deploy

RenkuBot commented 1 month ago

You can access the deployment of this PR at https://renku-ci-ui-3245.dev.renku.ch

lorenzo-cavazzi commented 1 month ago

I'm finishing a review on this, hold on a few minutes :pray: Sorry for the delay

leafty commented 1 month ago
  • Nitpick: when clicking on the filters, the line <n> results for <filters> immediately shows the new selection for the filters, but the number is updated later, when the API response arrives (I hope it's visible on the low-quality video). That's not a big deal, but it would be nice to either update them at the same time (it's fine if it's a little delayed) or show a loader instead of the number while waiting for the API response

Done

  • The application seems to refresh entirely when changing the search parameters (see video where re-drawn components flash). I assume there aren't other ways since we are changing the URL but the WebSocket channel gets re-created every time. I'm wondering if there is any way to address this.

Nothing we can do until we refactor how the app is bootstrapped (src/index, src/App).

RenkuBot commented 1 month ago

Tearing down the temporary RenkuLab deplyoment for this PR.