search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

[wip]feat: add playful 404 and error pages #3248

Open andre-code opened 1 month ago

andre-code commented 1 month ago

Playful 404 and error pages

Cases to test: Cases current Renku

Cases Renku 2.0

Screenshots NOT FOUND GROUP

Screenshot 2024-07-26 at 14 21 37 Screenshot 2024-07-26 at 14 21 18

Screenshot 2024-07-26 at 14 20 44 Screenshot 2024-07-26 at 14 20 29

fix #3235

/deploy

RenkuBot commented 1 month ago

You can access the deployment of this PR at https://renku-ci-ui-3248.dev.renku.ch

lorenzo-cavazzi commented 1 month ago

P.S. Sorry I missed that this PR was still a draft :facepalm: I hope the comments help anyway

andre-code commented 1 month ago

Thanks, @lorenzo-cavazzi, for your helpful suggestions.

Regarding the flashing information, I'm unsure how to address it. The info is the loading message indicating what is being searched for, but since, in the best case, this query is resolved quickly, it shows our 'not found' page in seconds. There isn't enough time to read the loading message.

So, I am not sure whether to delay the query response or leave it as it is. Do you have a suggestion for this case? I've already included your other suggestions in the latest commit.

lorenzo-cavazzi commented 3 weeks ago

Thanks, @lorenzo-cavazzi, for your helpful suggestions.

Regarding the flashing information, I'm unsure how to address it. The info is the loading message indicating what is being searched for, but since, in the best case, this query is resolved quickly, it shows our 'not found' page in seconds. There isn't enough time to read the loading message.

So, I am not sure whether to delay the query response or leave it as it is. Do you have a suggestion for this case? I've already included your other suggestions in the latest commit.

Oh I see now that your PR didn't introduce this problem. Then let's ignore it. The solution would be to put the content into a ContainerWrap so it's properly aligned with the rest of the application.