search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

fix: prevent querying sessions launchers without project id #3313

Closed lorenzo-cavazzi closed 2 months ago

lorenzo-cavazzi commented 2 months ago

When starting a session, the session_launchers endpoints is invoked too early when the project id isn't available yet. This prevents it

image

/deploy

RenkuBot commented 2 months ago

You can access the deployment of this PR at https://renku-ci-ui-3313.dev.renku.ch

andre-code commented 2 months ago

Thanks to @lorenzo for fixing this!

@leafty, could you clarify what you mean by "not well handled"? I see that the buttons displayed are incorrect. Is there anything else we need to address? If so, we should consider handling those issues in a separate PR.

Screenshot 2024-09-13 at 16 08 28

leafty commented 2 months ago

Thanks to @lorenzo for fixing this!

@leafty, could you clarify what you mean by "not well handled"? I see that the buttons displayed are incorrect. Is there anything else we need to address? If so, we should consider handling those issues in a separate PR.

We can open a new issue for this, but the component doesn't handle properly when its props are null-ish values

lorenzo-cavazzi commented 2 months ago

We can open a new issue for this, but the component doesn't handle properly when its props are null-ish values

@leafty That's a fair point. Since we are fixing the component already, I've added a quick solution for handling invalid namespace/slug values.

RenkuBot commented 2 months ago

Tearing down the temporary RenkuLab deplyoment for this PR.