search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

feat: handle connected services in the admin panel #3329

Closed lorenzo-cavazzi closed 1 month ago

lorenzo-cavazzi commented 2 months ago

Handle connected services in the admin panel.

image

/deploy

RenkuBot commented 2 months ago

You can access the deployment of this PR at https://renku-ci-ui-3329.dev.renku.ch

lorenzo-cavazzi commented 2 months ago

@leafty Thank you for the early review. I incorporated your suggestions and finished the PR.

P.S. Sorry for rebasing; I changed the target branch to main and the history was :face_with_spiral_eyes:

lorenzo-cavazzi commented 1 month ago

@leafty Thank you for the review. I applied your suggestions and fixed the problem with the client secret

lorenzo-cavazzi commented 1 month ago

@leafty I implemented your second batch of suggestions; thanks for taking the time to go through the PR again. That helps in reducing the follow-up fixes/improvements :D

I noticed that IDs with spaces are accepted, but editing/deleting those services triggers errors. Any idea what could be wrong? P.S: I added a disabled input to show the ID in the "update" modal.

Screenshot_20241003_111127

leafty commented 1 month ago

I noticed that IDs with spaces are accepted, but editing/deleting those services triggers errors. Any idea what could be wrong? P.S: I added a disabled input to show the ID in the "update" modal.

This is a bug with the backend, I will have to fix it.

RenkuBot commented 1 month ago

Tearing down the temporary RenkuLab deplyoment for this PR.