search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

feat: support permissions from the API #3351

Closed leafty closed 1 month ago

leafty commented 1 month ago

Fixes #3350.

See also: https://github.com/SwissDataScienceCenter/renku-data-services/pull/454, https://github.com/SwissDataScienceCenter/renku-data-services/issues/453.

/deploy renku-data-services=main renku=release-0.59.0

RenkuBot commented 1 month ago

You can access the deployment of this PR at https://renku-ci-ui-3351.dev.renku.ch

leafty commented 1 month ago

Nice work! Just a generic comment: do we want to show a disabled button for users without permissions, or should we hide the button completely instead? The second option seems the most popular on other similar platforms.

image

If we keep the current approach, I'm wondering if we should at least remove the button for non-logged users.

This PR does not change the UI, any such consideration should be for another PR after consultation with the product team.

lorenzo-cavazzi commented 1 month ago

I'm ok with keeping the approach on this PR. It changes how it looks for anonymous users (at least for a few buttons, didn't check all of them), but that's not a blocker.

@ciyer feel free to approve the PR if you have reviewed it since I didn't check the code. Otherwise, I'll do it when I'm back next Tuesday

RenkuBot commented 1 month ago

Tearing down the temporary RenkuLab deplyoment for this PR.