SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

fix: update project and group membership settings #3374

Closed leafty closed 1 month ago

leafty commented 1 month ago

On project settings:

On group settings:

/deploy renku=release-0.59.0

RenkuBot commented 1 month ago

You can access the deployment of this PR at https://renku-ci-ui-3374.dev.renku.ch

leafty commented 1 month ago

The code looks good overall! Just a couple of visual details to adjust (see inline).

One nitpick detail: when changing the access level, on the group page the Change button is disabled until you pick a different access level. On the project page, it's always enabled (see screenshot). It's just a detail, but perhaps you can update the project page too

Question about these style adjustments: should these be updated on the Project components too? The modals where adapted from the Project case.

lorenzo-cavazzi commented 1 month ago

Question about these style adjustments: should these be updated on the Project components too? The modals where adapted from the Project case.

It's great if you want to fix those too, to keep them all consistent, although I don't want to force you to inflate the PR with changes on other components.

RenkuBot commented 1 month ago

Tearing down the temporary RenkuLab deplyoment for this PR.