search

SwissDataScienceCenter / renku-ui

The web frontend of the Renku platform
https://renkulab.io
Apache License 2.0
13 stars 6 forks source link

fix: reset state of data connectors on modal close #3406

Closed ciyer closed 17 hours ago

ciyer commented 1 week ago

After closing the data connector modal, some state would be retained, causing bugs.

Testing

The bugs would occur when a second data connector was created immediately after the first. For example, one data connector was created, and then a second data connector was started, but canceled (e.g., by closing the dialog), the second would get created anyway. Check that these situations do not happen anymore

/deploy renku=release-0.61.0

RenkuBot commented 1 week ago

You can access the deployment of this PR at https://renku-ci-ui-3406.dev.renku.ch

ciyer commented 1 day ago

The code looks great and does the job well!

I just noticed that when editing a data connector, it’s not possible to change its visibility. Is that how it’s supposed to work?

Also, when editing a data connector I found the message “project was not linked” a bit confusing, what exactly does it mean?

Thanks for pointing these out! They are both bugs which I have been able to fix.

RenkuBot commented 17 hours ago

Tearing down the temporary RenkuLab deplyoment for this PR.