SwissDataScienceCenter / renku

Renku provides a platform and tools for reproducible and collaborative data analysis.
https://renkulab.io
Apache License 2.0
224 stars 34 forks source link

Enable subdomains #530

Open pameladelgado opened 5 years ago

pameladelgado commented 5 years ago

Renku components, for instance when redirecting, assume that there is a common single domain defined. In some cases (e.g. OpenShift deployment) we need to have subdomains for the different exposed services of Renku. Related issue: #190

rokroskar commented 5 years ago

you are sure that the issue was subdomain and not a misconfiguration?

rokroskar commented 5 years ago

case in point - I tried running gitlab on a subdomain using the gitlab cloud-native chart and it worked without problems. There really isn't much that needs to be done for that apart from specifying the correct URLs everywhere. But I have not tried the gateway in this mode. I am a bit surprised that openshift routing can't be done on subpaths -- I think we need to understand better why that is.

pameladelgado commented 5 years ago

It is fine that gitlab is able to work on a subdomain, but not sure about other components. @rokroskar have you tried having two different subdomains for gateway and ui? The problem is with the gateway, it might be that some code parts are not using the env variable for ui (we might be wrong, @lorenzo-cavazzi took a look at the code).