search

SwissDataScienceCenter / renkulab-docker

Source of docker images used for interactive sessions on Renkulab
https://renkulab.io
Apache License 2.0
14 stars 15 forks source link

chore: do not override RSTUDIO_VERSION in CI #439

Closed rokroskar closed 3 months ago

rokroskar commented 5 months ago

No double-override.

rokroskar commented 5 months ago

@leafty I can't tell what https://github.com/SwissDataScienceCenter/renkulab-docker/pull/439/commits/52cb8a6db681cc557f690993c8a4ff353e20472e does since most of it is blank space changes... could you not change the indentation?

leafty commented 5 months ago

@leafty I can't tell what 52cb8a6 does since most of it is blank space changes... could you not change the indentation?

Sorry, I removed two instances of {{ env.RSTUDIO_VERSION }} and format-on-save kicked in.

leafty commented 5 months ago

@rokroskar I think we should disable the tests until they are fixed and merge this. The images seem to be working (or we need to manually check all of them).

rokroskar commented 5 months ago

@leafty yes sure, that sounds good. I'm not really up to speed on how to fix these tests so some help would be appreciated there...

leafty commented 5 months ago

tests may be a bit flaky now, but they should ultimately pass

rokroskar commented 4 months ago

Sorry @leafty I missed that you had updated the tests here. Thanks for that! @olevski could you please review when you get a chance?