TRICC crashes with diagrams without images - Githubissues

SwissTPH / tricc

Tool for rapid implementation of clinical content (TRICC) for CDSS/XFORM

3 stars 0 forks source link

TRICC crashes with diagrams without images #21

Open rukshn opened 9 months ago

rukshn commented 9 months ago

TRICC fails to compile a diagram and generate an output if the diagram doesn't contain any images, and crashes with an error failure to write the excel file. The error is due to no images being present in the diagram and temporary folder not being created to store the diagrams and the xform file.

Expected Behavior

Draw a custom diagram / workflow with or without images
Upload the diagram to TRICC web app
Convert the diagram in to xforms using tricc
Download the converted xform excel file

Current Behavior

When triggering the conversion function the TRICC script crashes
With error excel file cannot be created
This is due to

Possible Solution

Create a temporary image folder to bypass the error and generate the xform output
The image folder will still be empty but it won't make a difference for the functionality of the xform output

Steps to Reproduce (for bugs)

Draw a custom diagram without images
Upload the diagram to TRICC webapp
Run the convert function by clicking convert button

Context

Trying to test TRICC webb app with a custom drawn diagram other then sysref v31 diagram

Your Environment

Docker running Ubuntu LTS
Nodejs LTS (21+)
Python 3.11+

rukshn commented 9 months ago

Fixed with commit https://github.com/SwissTPH/tricc/commit/2557c715d6ac711857f7a8cca16c8ec39cad2232

rukshn commented 9 months ago

The issue exists in other strategies, but need to be fixed in other strategies, https://github.com/SwissTPH/tricc/commit/2557c715d6ac711857f7a8cca16c8ec39cad2232 only fix it for the XLSFormStrategy

rukshn commented 9 months ago

Merged to development branch with https://github.com/SwissTPH/tricc/commit/baaf1455ba99a810ec718ff5be83bc90b8b48891 :tada: