search

SwissalpS / replacer

tool that replaces nodes by clicking on them and another that inspects nodes and entities (Mod for Luanti/Minetest)
GNU Lesser General Public License v3.0
4 stars 3 forks source link

changing mode is cumbersome #6

Closed SwissalpS closed 4 years ago

SwissalpS commented 4 years ago

Let's use special+right-click to open a formspec with buttons to quickly switch modes.

SwissalpS commented 4 years ago

Have added a formspec to change mode. It can be triggered by special(fast)+right-click on a node and special(fast)+left-click anywhere including air. The branch is formspecModeChange I appreciate test-reports and comments before I merge the changes into master.

@coil0 @6r1d @S-S-X @OgelGames @BuckarooBanzay @HybridDog @Sokomine @int-ua

OgelGames commented 4 years ago

Nice, works perfectly 👍

S-S-X commented 4 years ago

Works well but few things I would like to be changed a bit:

  1. Do not hide button for mode that is in use, instead use some other indication for selected mode like background color / button color / add some markers to text like "> crust <" etc. or even set it as plain label if there's some problem with buttons.

  2. Now there's 2 triggers for form, I'd say it would be better to keep old special + rmb trigger for cycling modes because it is a lot faster and wont cause interrupts. Small thing but very good shortuct and feels like very big and annoying change after you've learned fast way to cycle modes,

Something like this for selection: maybe just a little better texture :D screenshot_20200131_161217

SwissalpS commented 4 years ago

thanks SX, once again very good input :D

SwissalpS commented 4 years ago

I'm quite happy with this state 7a41f02

S-S-X commented 4 years ago

Didn't find any new problems, I'd say this is good enough for pr+merge.

Unless you want to start fixing old issues, that one mode marked as "TODO" in chat message can be selected via sepcial + rmb. Form also works well enough there as it does not "highlight" any of the selections.

I'd say open another issue for this one, it was already there before these changes.

SwissalpS commented 4 years ago

Yes, I kept mode 4 TODO in as reminder and agree totally separate issue.