SwitchCraftCC / Plethora-Fabric

A peripheral provider for ComputerCraft, ported to Fabric
MIT License
16 stars 13 forks source link

Add Plethora metadata for Item Magnets #90

Closed znepb closed 8 months ago

znepb commented 1 year ago

I'm suggesting chat messages be sent for updates with the item magnet, such as toggle notifications, and low charge notifications. I can make a PR if this suggestion is approved.

Lemmmy commented 1 year ago

I think a better approach would be to make sure Plethora can read magnet information (it can get the damage, but can it access Trinkets slots via getEquipment?) and then the user can set up whatever notifications they want.

Kan18 commented 8 months ago

Plethora can get metadata from Trinkets slots (via getMetaOwner, etc.) since https://github.com/SwitchCraftCC/Plethora-Fabric/commit/d9683ca76b863a972d5897d414ea7215fac52d0d

image
Lemmmy commented 8 months ago

Closed by 64fbf40bedcdc24a065b9acd003424069484f3d3