search

SwitchCraftCC / sc-goodies

Custom content for the SwitchCraft server
MIT License
10 stars 10 forks source link

Grass types can be turned into farmland and paths #46

Closed penguinencounter closed 1 year ago

penguinencounter commented 1 year ago

Fixes #42.

The goodies grass types can be turned into farmland (use a hoe item) or dirt paths (use a shovel item).

penguinencounter commented 1 year ago

Would it be possible to gitignore the cache folder? I had to do a conflict resolution pass on it...

Lemmmy commented 1 year ago

Thanks for the PR!

Fabric has a registry for tillable blocks and pathable blocks - TillableBlockRegistry and FlattenableBlockRegistry. We already use the FlattenableBlockRegistry for paths:

https://github.com/SwitchCraftCC/sc-goodies/blob/3d03a7364dfc3e543bc34dc8f5ed2b1c7b04a5b9/src/main/kotlin/io/sc3/goodies/Registration.kt#L164-L166

Did you test if using a shovel to make path already worked without your PR? It should do - if not, that is a bug. For hoe items, please use the Fabric registry (in the same place in Registration as above) instead of a mixin so we can avoid potential conflict with the Fabric API.

Would it be possible to gitignore the cache folder? I had to do a conflict resolution pass on it...

The Fabric example mod doesn't gitignore the .cache folder, so we trust their decision not to.

penguinencounter commented 1 year ago

oops! did not know it would do that (force-pushed a reset to 1.20.1)

Lemmmy commented 1 year ago

Brilliant, thank you!